usb: gadget: omap_udc: remove possiblity of NULL pointer de-reference

when allocating a request, it's better programming
practice to make sure we return NULL if allocation
failed.

This will ensure that, if struct usb_request isn't
the first member on our structure, we don't cheat
the gadget driver into thinking allocating worked
because pointer isn't 0.

Signed-off-by: Felipe Balbi <balbi@ti.com>

diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c
index 814aafbed0006accca5329ac11fc165aa40aa90b..f13bcdc756760eedd38c346bb85614b059a3938c 100644 (file)
--- a/drivers/usb/gadget/omap_udc.c
+++ b/drivers/usb/gadget/omap_udc.c
@@ -268,10 +268,12 @@ omap_alloc_request(struct usb_ep *ep, gfp_t gfp_flags)
        struct omap_req *req;
 
        req = kzalloc(sizeof(*req), gfp_flags);
-       if (req) {
-               req->req.dma = DMA_ADDR_INVALID;
-               INIT_LIST_HEAD(&req->queue);
-       }
+       if (!req)
+               return NULL;
+
+       req->req.dma = DMA_ADDR_INVALID;
+       INIT_LIST_HEAD(&req->queue);
+
        return &req->req;
 }