aha1542: Fix bus reset
authorOndrej Zary <linux@rainbow-software.org>
Fri, 6 Feb 2015 22:11:56 +0000 (23:11 +0100)
committerJames Bottomley <JBottomley@Odin.com>
Fri, 10 Apr 2015 01:09:30 +0000 (18:09 -0700)
Bus reset always fails because aha1542_reset waits for the controller to assert
the INIT bit (Mailbox Initialization Required) which it never does. This bit is
asserted only after host reset.

Remove the requirement for INIT bit (we really need only the IDLE bit).

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
drivers/scsi/aha1542.c

index 7b5d396deaa52fd69c41e0ce46104f28bf5aab90..af821f340a85452d6f5e1c876f49d1b3827bf301 100644 (file)
@@ -867,7 +867,7 @@ static int aha1542_reset(struct scsi_cmnd *cmd, u8 reset_cmd)
        outb(reset_cmd, CONTROL(cmd->device->host->io_port));
 
        if (!wait_mask(STATUS(cmd->device->host->io_port),
-            STATMASK, INIT | IDLE, STST | DIAGF | INVDCMD | DF | CDF, 0)) {
+            STATMASK, IDLE, STST | DIAGF | INVDCMD | DF | CDF, 0)) {
                spin_unlock_irqrestore(sh->host_lock, flags);
                return FAILED;
        }