Merge branch 'topic/of' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie...
authorMark Brown <broonie@linaro.org>
Mon, 10 Feb 2014 13:31:02 +0000 (13:31 +0000)
committerMark Brown <broonie@linaro.org>
Mon, 10 Feb 2014 13:31:02 +0000 (13:31 +0000)
include/sound/simple_card.h
sound/soc/generic/simple-card.c

index 6c74527d4926b3e476428fb6327652d9ca22dfbb..e1ac996c8febeba408a5930aff4ff030d820241f 100644 (file)
@@ -29,10 +29,6 @@ struct asoc_simple_card_info {
        unsigned int daifmt;
        struct asoc_simple_dai cpu_dai;
        struct asoc_simple_dai codec_dai;
-
-       /* used in simple-card.c */
-       struct snd_soc_dai_link snd_link;
-       struct snd_soc_card snd_card;
 };
 
 #endif /* __SIMPLE_CARD_H */
index 2a1b1b5b5221089f32e395087e9c4651ddd00799..0890fcdc9251528e40087872d6584254749a62f6 100644 (file)
 #include <linux/string.h>
 #include <sound/simple_card.h>
 
+struct simple_card_data {
+       struct snd_soc_card snd_card;
+       unsigned int daifmt;
+       struct asoc_simple_dai cpu_dai;
+       struct asoc_simple_dai codec_dai;
+       struct snd_soc_dai_link snd_link;
+};
+
 static int __asoc_simple_card_dai_init(struct snd_soc_dai *dai,
-                                      struct asoc_simple_dai *set,
-                                      unsigned int daifmt)
+                                      struct asoc_simple_dai *set)
 {
-       int ret = 0;
-
-       daifmt |= set->fmt;
-
-       if (daifmt)
-               ret = snd_soc_dai_set_fmt(dai, daifmt);
+       int ret;
 
-       if (ret == -ENOTSUPP) {
-               dev_dbg(dai->dev, "ASoC: set_fmt is not supported\n");
-               ret = 0;
+       if (set->fmt) {
+               ret = snd_soc_dai_set_fmt(dai, set->fmt);
+               if (ret && ret != -ENOTSUPP) {
+                       dev_err(dai->dev, "simple-card: set_fmt error\n");
+                       goto err;
+               }
        }
 
-       if (!ret && set->sysclk)
+       if (set->sysclk) {
                ret = snd_soc_dai_set_sysclk(dai, 0, set->sysclk, 0);
+               if (ret && ret != -ENOTSUPP) {
+                       dev_err(dai->dev, "simple-card: set_sysclk error\n");
+                       goto err;
+               }
+       }
+
+       ret = 0;
 
+err:
        return ret;
 }
 
 static int asoc_simple_card_dai_init(struct snd_soc_pcm_runtime *rtd)
 {
-       struct asoc_simple_card_info *info =
+       struct simple_card_data *priv =
                                snd_soc_card_get_drvdata(rtd->card);
        struct snd_soc_dai *codec = rtd->codec_dai;
        struct snd_soc_dai *cpu = rtd->cpu_dai;
-       unsigned int daifmt = info->daifmt;
        int ret;
 
-       ret = __asoc_simple_card_dai_init(codec, &info->codec_dai, daifmt);
+       ret = __asoc_simple_card_dai_init(codec, &priv->codec_dai);
        if (ret < 0)
                return ret;
 
-       ret = __asoc_simple_card_dai_init(cpu, &info->cpu_dai, daifmt);
+       ret = __asoc_simple_card_dai_init(cpu, &priv->cpu_dai);
        if (ret < 0)
                return ret;
 
@@ -59,9 +71,12 @@ static int asoc_simple_card_dai_init(struct snd_soc_pcm_runtime *rtd)
 
 static int
 asoc_simple_card_sub_parse_of(struct device_node *np,
+                             unsigned int daifmt,
                              struct asoc_simple_dai *dai,
-                             struct device_node **node)
+                             const struct device_node **p_node,
+                             const char **name)
 {
+       struct device_node *node;
        struct clk *clk;
        int ret;
 
@@ -69,12 +84,13 @@ asoc_simple_card_sub_parse_of(struct device_node *np,
         * get node via "sound-dai = <&phandle port>"
         * it will be used as xxx_of_node on soc_bind_dai_link()
         */
-       *node = of_parse_phandle(np, "sound-dai", 0);
-       if (!*node)
+       node = of_parse_phandle(np, "sound-dai", 0);
+       if (!node)
                return -ENODEV;
+       *p_node = node;
 
        /* get dai->name */
-       ret = snd_soc_of_get_dai_name(np, &dai->name);
+       ret = snd_soc_of_get_dai_name(np, name);
        if (ret < 0)
                goto parse_error;
 
@@ -84,6 +100,7 @@ asoc_simple_card_sub_parse_of(struct device_node *np,
         * and specific "format" if it has
         */
        dai->fmt = snd_soc_of_parse_daifmt(np, NULL);
+       dai->fmt |= daifmt;
 
        /*
         * dai->sysclk come from
@@ -104,7 +121,7 @@ asoc_simple_card_sub_parse_of(struct device_node *np,
                                     "system-clock-frequency",
                                     &dai->sysclk);
        } else {
-               clk = of_clk_get(*node, 0);
+               clk = of_clk_get(node, 0);
                if (!IS_ERR(clk))
                        dai->sysclk = clk_get_rate(clk);
        }
@@ -112,29 +129,30 @@ asoc_simple_card_sub_parse_of(struct device_node *np,
        ret = 0;
 
 parse_error:
-       of_node_put(*node);
+       of_node_put(node);
 
        return ret;
 }
 
 static int asoc_simple_card_parse_of(struct device_node *node,
-                                    struct asoc_simple_card_info *info,
-                                    struct device *dev,
-                                    struct device_node **of_cpu,
-                                    struct device_node **of_codec,
-                                    struct device_node **of_platform)
+                                    struct simple_card_data *priv,
+                                    struct device *dev)
 {
+       struct snd_soc_dai_link *dai_link = priv->snd_card.dai_link;
        struct device_node *np;
        char *name;
        int ret;
 
+       /* parsing the card name from DT */
+       snd_soc_of_parse_card_name(&priv->snd_card, "simple-audio-card,name");
+
        /* get CPU/CODEC common format via simple-audio-card,format */
-       info->daifmt = snd_soc_of_parse_daifmt(node, "simple-audio-card,") &
+       priv->daifmt = snd_soc_of_parse_daifmt(node, "simple-audio-card,") &
                (SND_SOC_DAIFMT_FORMAT_MASK | SND_SOC_DAIFMT_INV_MASK);
 
        /* DAPM routes */
        if (of_property_read_bool(node, "simple-audio-card,routing")) {
-               ret = snd_soc_of_parse_audio_routing(&info->snd_card,
+               ret = snd_soc_of_parse_audio_routing(&priv->snd_card,
                                        "simple-audio-card,routing");
                if (ret)
                        return ret;
@@ -144,9 +162,10 @@ static int asoc_simple_card_parse_of(struct device_node *node,
        ret = -EINVAL;
        np = of_get_child_by_name(node, "simple-audio-card,cpu");
        if (np)
-               ret = asoc_simple_card_sub_parse_of(np,
-                                                 &info->cpu_dai,
-                                                 of_cpu);
+               ret = asoc_simple_card_sub_parse_of(np, priv->daifmt,
+                                                 &priv->cpu_dai,
+                                                 &dai_link->cpu_of_node,
+                                                 &dai_link->cpu_dai_name);
        if (ret < 0)
                return ret;
 
@@ -154,114 +173,113 @@ static int asoc_simple_card_parse_of(struct device_node *node,
        ret = -EINVAL;
        np = of_get_child_by_name(node, "simple-audio-card,codec");
        if (np)
-               ret = asoc_simple_card_sub_parse_of(np,
-                                                 &info->codec_dai,
-                                                 of_codec);
+               ret = asoc_simple_card_sub_parse_of(np, priv->daifmt,
+                                                 &priv->codec_dai,
+                                                 &dai_link->codec_of_node,
+                                                 &dai_link->codec_dai_name);
        if (ret < 0)
                return ret;
 
-       if (!info->cpu_dai.name || !info->codec_dai.name)
+       if (!dai_link->cpu_dai_name || !dai_link->codec_dai_name)
                return -EINVAL;
 
        /* card name is created from CPU/CODEC dai name */
        name = devm_kzalloc(dev,
-                           strlen(info->cpu_dai.name)   +
-                           strlen(info->codec_dai.name) + 2,
+                           strlen(dai_link->cpu_dai_name)   +
+                           strlen(dai_link->codec_dai_name) + 2,
                            GFP_KERNEL);
-       sprintf(name, "%s-%s", info->cpu_dai.name, info->codec_dai.name);
-       info->name = info->card = name;
+       sprintf(name, "%s-%s", dai_link->cpu_dai_name,
+                               dai_link->codec_dai_name);
+       if (!priv->snd_card.name)
+               priv->snd_card.name = name;
+       dai_link->name = dai_link->stream_name = name;
 
        /* simple-card assumes platform == cpu */
-       *of_platform = *of_cpu;
+       dai_link->platform_of_node = dai_link->cpu_of_node;
 
-       dev_dbg(dev, "card-name : %s\n", info->card);
-       dev_dbg(dev, "platform : %04x\n", info->daifmt);
+       dev_dbg(dev, "card-name : %s\n", name);
+       dev_dbg(dev, "platform : %04x\n", priv->daifmt);
        dev_dbg(dev, "cpu : %s / %04x / %d\n",
-               info->cpu_dai.name,
-               info->cpu_dai.fmt,
-               info->cpu_dai.sysclk);
+               dai_link->cpu_dai_name,
+               priv->cpu_dai.fmt,
+               priv->cpu_dai.sysclk);
        dev_dbg(dev, "codec : %s / %04x / %d\n",
-               info->codec_dai.name,
-               info->codec_dai.fmt,
-               info->codec_dai.sysclk);
+               dai_link->codec_dai_name,
+               priv->codec_dai.fmt,
+               priv->codec_dai.sysclk);
 
        return 0;
 }
 
 static int asoc_simple_card_probe(struct platform_device *pdev)
 {
-       struct asoc_simple_card_info *cinfo;
+       struct simple_card_data *priv;
+       struct snd_soc_dai_link *dai_link;
        struct device_node *np = pdev->dev.of_node;
-       struct device_node *of_cpu, *of_codec, *of_platform;
        struct device *dev = &pdev->dev;
        int ret;
 
-       cinfo           = NULL;
-       of_cpu          = NULL;
-       of_codec        = NULL;
-       of_platform     = NULL;
-
-       cinfo = devm_kzalloc(dev, sizeof(*cinfo), GFP_KERNEL);
-       if (!cinfo)
+       priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+       if (!priv)
                return -ENOMEM;
 
+       /*
+        * init snd_soc_card
+        */
+       priv->snd_card.owner = THIS_MODULE;
+       priv->snd_card.dev = dev;
+       dai_link = &priv->snd_link;
+       priv->snd_card.dai_link = dai_link;
+       priv->snd_card.num_links = 1;
+
        if (np && of_device_is_available(np)) {
-               cinfo->snd_card.dev = dev;
 
-               ret = asoc_simple_card_parse_of(np, cinfo, dev,
-                                               &of_cpu,
-                                               &of_codec,
-                                               &of_platform);
+               ret = asoc_simple_card_parse_of(np, priv, dev);
                if (ret < 0) {
                        if (ret != -EPROBE_DEFER)
                                dev_err(dev, "parse error %d\n", ret);
                        return ret;
                }
        } else {
-               if (!dev->platform_data) {
+               struct asoc_simple_card_info *cinfo;
+
+               cinfo = dev->platform_data;
+               if (!cinfo) {
                        dev_err(dev, "no info for asoc-simple-card\n");
                        return -EINVAL;
                }
 
-               memcpy(cinfo, dev->platform_data, sizeof(*cinfo));
-               cinfo->snd_card.dev = dev;
-       }
+               if (!cinfo->name        ||
+                   !cinfo->card        ||
+                   !cinfo->codec_dai.name      ||
+                   !cinfo->codec       ||
+                   !cinfo->platform    ||
+                   !cinfo->cpu_dai.name) {
+                       dev_err(dev, "insufficient asoc_simple_card_info settings\n");
+                       return -EINVAL;
+               }
 
-       if (!cinfo->name        ||
-           !cinfo->card        ||
-           !cinfo->codec_dai.name      ||
-           !(cinfo->codec              || of_codec)    ||
-           !(cinfo->platform           || of_platform) ||
-           !(cinfo->cpu_dai.name       || of_cpu)) {
-               dev_err(dev, "insufficient asoc_simple_card_info settings\n");
-               return -EINVAL;
+               priv->snd_card.name     = cinfo->card;
+               dai_link->name          = cinfo->name;
+               dai_link->stream_name   = cinfo->name;
+               dai_link->platform_name = cinfo->platform;
+               dai_link->codec_name    = cinfo->codec;
+               dai_link->cpu_dai_name  = cinfo->cpu_dai.name;
+               dai_link->codec_dai_name = cinfo->codec_dai.name;
+               memcpy(&priv->cpu_dai, &cinfo->cpu_dai,
+                                               sizeof(priv->cpu_dai));
+               memcpy(&priv->codec_dai, &cinfo->codec_dai,
+                                               sizeof(priv->codec_dai));
        }
 
        /*
         * init snd_soc_dai_link
         */
-       cinfo->snd_link.name            = cinfo->name;
-       cinfo->snd_link.stream_name     = cinfo->name;
-       cinfo->snd_link.cpu_dai_name    = cinfo->cpu_dai.name;
-       cinfo->snd_link.platform_name   = cinfo->platform;
-       cinfo->snd_link.codec_name      = cinfo->codec;
-       cinfo->snd_link.codec_dai_name  = cinfo->codec_dai.name;
-       cinfo->snd_link.cpu_of_node     = of_cpu;
-       cinfo->snd_link.codec_of_node   = of_codec;
-       cinfo->snd_link.platform_of_node = of_platform;
-       cinfo->snd_link.init            = asoc_simple_card_dai_init;
-
-       /*
-        * init snd_soc_card
-        */
-       cinfo->snd_card.name            = cinfo->card;
-       cinfo->snd_card.owner           = THIS_MODULE;
-       cinfo->snd_card.dai_link        = &cinfo->snd_link;
-       cinfo->snd_card.num_links       = 1;
+       dai_link->init = asoc_simple_card_dai_init;
 
-       snd_soc_card_set_drvdata(&cinfo->snd_card, cinfo);
+       snd_soc_card_set_drvdata(&priv->snd_card, priv);
 
-       return devm_snd_soc_register_card(&pdev->dev, &cinfo->snd_card);
+       return devm_snd_soc_register_card(&pdev->dev, &priv->snd_card);
 }
 
 static const struct of_device_id asoc_simple_of_match[] = {