(wangle) remove Future::wait

Summary: pulling the trigger

Test Plan: Unit tests. Wait for contbuild and dependent unit tests

Reviewed By: hannesr@fb.com

FB internal diff: D1184842

diff --git a/folly/wangle/Future.h b/folly/wangle/Future.h
index 48e8822e57f49307db3e3d069b97e3e1e3da01e1..354a0bae953ad69d15fea381dd149f24f4cd3f76 100644 (file)
--- a/folly/wangle/Future.h
+++ b/folly/wangle/Future.h
@@ -79,19 +79,6 @@ class Future {
       when this returns true. */
   bool isReady() const;
 
-  /** Wait until the result (or exception) is ready. Once this returns,
-    value() will not block, and isReady() will return true.
-
-    XXX This implementation is simplistic and inefficient, but it does work
-    and a fully intelligent implementation is coming down the pipe.
-  */
-  void wait() const {
-    while (!isReady()) {
-      // spin
-      std::this_thread::yield();
-    }
-  }
-
   Try<T>& valueTry();
 
   /** When this Future has completed, execute func which is a function that

diff --git a/folly/wangle/test/FutureTest.cpp b/folly/wangle/test/FutureTest.cpp
index cdc8f82d7b659265875dcd22967e5eb82c3782d3..24a318f2357aabd0c284d15982de085ea057064a 100644 (file)
--- a/folly/wangle/test/FutureTest.cpp
+++ b/folly/wangle/test/FutureTest.cpp
@@ -500,21 +500,6 @@ TEST(when, small_vector) {
   }
 }
 
-TEST(Future, wait) {
-  Promise<void> p;
-  auto f = p.getFuture();
-  auto t = std::thread([&] {
-    std::this_thread::sleep_for(std::chrono::microseconds(10));
-    p.setValue();
-  });
-
-  f.wait();
-
-  EXPECT_TRUE(f.isReady());
-
-  t.join();
-}
-
 TEST(Future, whenAllVariadic) {
   Promise<bool> pb;
   Promise<int> pi;