[POWERPC] kexec: MPIC ack interrupts at mpic_teardown_this_cpu()
authorValentine Barshak <vbarshak@ru.mvista.com>
Thu, 3 Apr 2008 19:09:43 +0000 (23:09 +0400)
committerOlof Johansson <olof@lixom.net>
Mon, 7 Apr 2008 14:16:29 +0000 (09:16 -0500)
We really need to ack interrupts at mpic_teardown, since
not all platforms reset mpic at kernel start-up. For example,
kexec'ed kernel hangs on P.A. Semi if mpic_eoi() isn't called.

Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
Signed-off-by: Olof Johansson <olof@lixom.net>
arch/powerpc/sysdev/mpic.c

index 6131fd2b6619c0ea26e06e2dccea125d89e3486b..8619f2a3f1f637d685cf71d257fb47efd2f29f85 100644 (file)
@@ -1410,11 +1410,6 @@ void mpic_cpu_set_priority(int prio)
        mpic_cpu_write(MPIC_INFO(CPU_CURRENT_TASK_PRI), prio);
 }
 
-/*
- * XXX: someone who knows mpic should check this.
- * do we need to eoi the ipi including for kexec cpu here (see xics comments)?
- * or can we reset the mpic in the new kernel?
- */
 void mpic_teardown_this_cpu(int secondary)
 {
        struct mpic *mpic = mpic_primary;
@@ -1434,6 +1429,10 @@ void mpic_teardown_this_cpu(int secondary)
 
        /* Set current processor priority to max */
        mpic_cpu_write(MPIC_INFO(CPU_CURRENT_TASK_PRI), 0xf);
+       /* We need to EOI the IPI since not all platforms reset the MPIC
+        * on boot and new interrupts wouldn't get delivered otherwise.
+        */
+       mpic_eoi(mpic);
 
        spin_unlock_irqrestore(&mpic_lock, flags);
 }