amd64_edac: fix interleave enable tests
authorBorislav Petkov <borislav.petkov@amd.com>
Fri, 18 Sep 2009 10:27:27 +0000 (12:27 +0200)
committerBorislav Petkov <borislav.petkov@amd.com>
Wed, 7 Oct 2009 14:48:08 +0000 (16:48 +0200)
The pvt->dram_IntlvEn saves the 3 "Interleave Enable" bits already
right-shifted by 8 so the check in find_mc_by_sys_addr() by shifting the
values to the left 8 bits is wrong.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
drivers/edac/amd64_edac.c

index 6e2ccce225db36f2a74692baf9310b42713a6d2b..854c7c1250354982575e6514dcf19e6da7c7aa2e 100644 (file)
@@ -289,12 +289,12 @@ static struct mem_ctl_info *find_mc_by_sys_addr(struct mem_ctl_info *mci,
                goto found;
        }
 
-       if (unlikely((intlv_en != (0x01 << 8)) &&
-                    (intlv_en != (0x03 << 8)) &&
-                    (intlv_en != (0x07 << 8)))) {
+       if (unlikely((intlv_en != 0x01) &&
+                    (intlv_en != 0x03) &&
+                    (intlv_en != 0x07))) {
                amd64_printk(KERN_WARNING, "junk value of 0x%x extracted from "
                             "IntlvEn field of DRAM Base Register for node 0: "
-                            "This probably indicates a BIOS bug.\n", intlv_en);
+                            "this probably indicates a BIOS bug.\n", intlv_en);
                return NULL;
        }