Use WeakVH to hold dead mdnodes. Check use_empty() before deleting a node.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@80928 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/VMCore/LLVMContext.cpp b/lib/VMCore/LLVMContext.cpp
index 0ed21fb754ed7435c1fda49ccce334d26f8fff4c..887679e08d307200c4a915700f4f41a21a1b1b4d 100644 (file)
--- a/lib/VMCore/LLVMContext.cpp
+++ b/lib/VMCore/LLVMContext.cpp
@@ -17,6 +17,7 @@
 #include "llvm/Constants.h"
 #include "llvm/Instruction.h"
 #include "llvm/Support/ManagedStatic.h"
+#include "llvm/Support/ValueHandle.h"
 #include "LLVMContextImpl.h"
 #include <set>
 
@@ -45,24 +46,25 @@ GetElementPtrConstantExpr::GetElementPtrConstantExpr
 }
 
 bool LLVMContext::RemoveDeadMetadata() {
-  std::vector<const MDNode *> DeadMDNodes;
+  std::vector<WeakVH> DeadMDNodes;
   bool Changed = false;
   while (1) {
 
     for (FoldingSet<MDNode>::iterator 
            I = pImpl->MDNodeSet.begin(),
            E = pImpl->MDNodeSet.end(); I != E; ++I) {
-      const MDNode *N = &(*I);
+      MDNode *N = &(*I);
       if (N->use_empty()) 
-        DeadMDNodes.push_back(N);
+        DeadMDNodes.push_back(WeakVH(N));
     }
     
     if (DeadMDNodes.empty())
       return Changed;
 
     while (!DeadMDNodes.empty()) {
-      const MDNode *N = DeadMDNodes.back(); DeadMDNodes.pop_back();
-      delete N;
+      const MDNode *N = cast<MDNode>(DeadMDNodes.back()); DeadMDNodes.pop_back();
+      if (N->use_empty())
+       delete N;
     }
   }
   return Changed;