projects
/
firefly-linux-kernel-4.4.55.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b8017d2
)
ore: signedness bug in _sp2d_min_pg()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Tue, 2 Oct 2012 08:28:45 +0000
(11:28 +0300)
committer
Boaz Harrosh
<bharrosh@panasas.com>
Wed, 3 Oct 2012 20:51:51 +0000
(13:51 -0700)
This for loop doesn't work correctly when "p" is unsigned.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
fs/exofs/ore_raid.c
patch
|
blob
|
history
diff --git
a/fs/exofs/ore_raid.c
b/fs/exofs/ore_raid.c
index 5f376d14fdcc3c0d9791fce5f2951d35b54c778b..b963f38ac298e82404befa6265c171aca4584aba 100644
(file)
--- a/
fs/exofs/ore_raid.c
+++ b/
fs/exofs/ore_raid.c
@@
-203,7
+203,7
@@
static unsigned _sp2d_min_pg(struct __stripe_pages_2d *sp2d)
static unsigned _sp2d_max_pg(struct __stripe_pages_2d *sp2d)
{
-
unsigned
p;
+
int
p;
for (p = sp2d->pages_in_unit - 1; p >= 0; --p) {
struct __1_page_stripe *_1ps = &sp2d->_1p_stripes[p];