powerpc: Remove superfluous WARN_ON() from dma-noncoherent.c
authorHollis Blanchard <hollisb@us.ibm.com>
Mon, 10 Nov 2008 14:33:36 +0000 (14:33 +0000)
committerPaul Mackerras <paulus@samba.org>
Wed, 19 Nov 2008 05:04:52 +0000 (16:04 +1100)
I can't tell why this WARN_ON exists, and there's no comment
explaining it.  Whether the pmd is present or not, pte_alloc_kernel()
seems to handle both cases.

Booting a 440 kernel with 64K PAGE_SIZE triggers the warning, but boot
successfully completes and I see no problems beyond that.

Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/lib/dma-noncoherent.c

index 31734c0969cd28014b226f300f0b1932186ea4e1..2b1ce184934410f0fbb279ffb21ffbe870b92044 100644 (file)
@@ -320,7 +320,6 @@ static int __init dma_alloc_init(void)
                        ret = -ENOMEM;
                        break;
                }
-               WARN_ON(!pmd_none(*pmd));
 
                pte = pte_alloc_kernel(pmd, CONSISTENT_BASE);
                if (!pte) {