ath10k: Use TX cksum offload only for CHECKSUM_PARTIAL
authorHelmut Schaa <helmut.schaa@googlemail.com>
Wed, 28 Jan 2015 10:31:32 +0000 (11:31 +0100)
committerKalle Valo <kvalo@qca.qualcomm.com>
Wed, 4 Feb 2015 07:19:03 +0000 (09:19 +0200)
Otherwise ath10k will just checksum everything even if it did not
go through the TCP/IP stack (for example bridged frames). In the worst
case this could mean recreating the checksum for incorrect data.

Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
drivers/net/wireless/ath/ath10k/htt_tx.c

index c1961e77d58d839ac926e6b5282c13014cc7025f..cbd2bc9e62025fbdc861f4913b00f41c4222bbb9 100644 (file)
@@ -515,8 +515,10 @@ int ath10k_htt_tx(struct ath10k_htt *htt, struct sk_buff *msdu)
 
        flags1 |= SM((u16)vdev_id, HTT_DATA_TX_DESC_FLAGS1_VDEV_ID);
        flags1 |= SM((u16)tid, HTT_DATA_TX_DESC_FLAGS1_EXT_TID);
-       flags1 |= HTT_DATA_TX_DESC_FLAGS1_CKSUM_L3_OFFLOAD;
-       flags1 |= HTT_DATA_TX_DESC_FLAGS1_CKSUM_L4_OFFLOAD;
+       if (msdu->ip_summed == CHECKSUM_PARTIAL) {
+               flags1 |= HTT_DATA_TX_DESC_FLAGS1_CKSUM_L3_OFFLOAD;
+               flags1 |= HTT_DATA_TX_DESC_FLAGS1_CKSUM_L4_OFFLOAD;
+       }
 
        /* Prevent firmware from sending up tx inspection requests. There's
         * nothing ath10k can do with frames requested for inspection so force