video: fbdev-VIA: Deletion of an unnecessary check before the function call "framebuf...
authorMarkus Elfring <elfring@users.sourceforge.net>
Sun, 23 Nov 2014 15:30:05 +0000 (16:30 +0100)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 4 Dec 2014 14:16:02 +0000 (16:16 +0200)
The framebuffer_release() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/via/viafbdev.c

index 325c43c6ff973895eb6b4b573b330ad596295a6a..f9718f012aae9be85a9568a2ce7be0740f08f5f6 100644 (file)
@@ -1937,8 +1937,7 @@ out_fb1_unreg_lcd_cle266:
 out_dealloc_cmap:
        fb_dealloc_cmap(&viafbinfo->cmap);
 out_fb1_release:
-       if (viafbinfo1)
-               framebuffer_release(viafbinfo1);
+       framebuffer_release(viafbinfo1);
 out_fb_release:
        i2c_bus_free(viaparinfo->shared);
        framebuffer_release(viafbinfo);