staging: wilc1000: return error code directly in host_int_set_mac_chnl_num
authorChaehyun Lim <chaehyun.lim@gmail.com>
Mon, 5 Oct 2015 02:07:22 +0000 (11:07 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Oct 2015 09:52:45 +0000 (10:52 +0100)
There is no need to pass the error code to the variable 'result'.
Just return the error directly when error occurs.
Return 0 at the end of this function when error is not happened.

Suggested-by: Julian Calaby <julian.calaby@gmail.com>
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/host_interface.c

index 47ccaa81b660a3ba456ba1b4c64fa72441aedbe8..b1aa7dd701f779956ccdf38341a0723a8a25bc67 100644 (file)
@@ -5317,7 +5317,7 @@ s32 host_int_get_rx_power_level(tstrWILC_WFIDrv *hWFIDrv, u8 *pu8RxPowerLevel,
  */
 int host_int_set_mac_chnl_num(tstrWILC_WFIDrv *wfi_drv, u8 channel)
 {
-       int result = 0;
+       int result;
        struct host_if_msg msg;
 
        if (!wfi_drv) {
@@ -5334,10 +5334,10 @@ int host_int_set_mac_chnl_num(tstrWILC_WFIDrv *wfi_drv, u8 channel)
        result = wilc_mq_send(&gMsgQHostIF, &msg, sizeof(struct host_if_msg));
        if (result) {
                PRINT_ER("wilc mq send fail\n");
-               result = -EINVAL;
+               return -EINVAL;
        }
 
-       return result;
+       return 0;
 }