usb: gadget: gr_udc: remove some unneeded error handling
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 17 Jan 2014 13:34:11 +0000 (16:34 +0300)
committerFelipe Balbi <balbi@ti.com>
Thu, 20 Feb 2014 15:16:17 +0000 (09:16 -0600)
Debugfs function return an ERR_PTR if they compiled out.  We don't need
to test for that here because if the debugfs file are compiled out then
it is ok to pass an ERR_PTR to debugfs_create_file() since it will just
be a no-op stub.

Debugfs return NULLs on error, but we don't need to test for that either
because debugfs_create_file() will accept NULL pointers.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/gr_udc.c

index 914cbd84ee40b8c6f14af524eb914d76c9c31aac..f984ee75324d33b9fcf248588a45801538812450 100644 (file)
@@ -225,14 +225,8 @@ static void gr_dfs_create(struct gr_udc *dev)
        const char *name = "gr_udc_state";
 
        dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), NULL);
-       if (IS_ERR(dev->dfs_root)) {
-               dev_err(dev->dev, "Failed to create debugfs directory\n");
-               return;
-       }
-       dev->dfs_state = debugfs_create_file(name, 0444, dev->dfs_root,
-                                            dev, &gr_dfs_fops);
-       if (IS_ERR(dev->dfs_state))
-               dev_err(dev->dev, "Failed to create debugfs file %s\n", name);
+       dev->dfs_state = debugfs_create_file(name, 0444, dev->dfs_root, dev,
+                                            &gr_dfs_fops);
 }
 
 static void gr_dfs_delete(struct gr_udc *dev)