usb: gadget: udc: net2280: remove full_speed module parameter
authorRicardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Fri, 28 Nov 2014 13:50:47 +0000 (14:50 +0100)
committerFelipe Balbi <balbi@ti.com>
Mon, 12 Jan 2015 18:13:27 +0000 (12:13 -0600)
This patch removes the full_speed parameter used force full-speed
operation.

It was designed exclusively for testing purposes, and there is no
reason to maintain this in a production kernel.

Reverts: 2f0760774711c957c395b31131b848043af98edf
Suggested-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/udc/net2280.c

index 08c16ee092f275ad89e5b58f45f650f9aa8effc2..27b94c69bef56439ee0e95f20eaebd6e615a5977 100644 (file)
@@ -113,11 +113,6 @@ static bool enable_suspend;
 /* "modprobe net2280 enable_suspend=1" etc */
 module_param(enable_suspend, bool, 0444);
 
-/* force full-speed operation */
-static bool full_speed;
-module_param(full_speed, bool, 0444);
-MODULE_PARM_DESC(full_speed, "force full-speed mode -- for testing only!");
-
 #define        DIR_STRING(bAddress) (((bAddress) & USB_DIR_IN) ? "in" : "out")
 
 static char *type_string(u8 bmAttributes)
@@ -2291,11 +2286,7 @@ static int net2280_start(struct usb_gadget *_gadget,
        if (retval)
                goto err_func;
 
-       /* Enable force-full-speed testing mode, if desired */
-       if (full_speed && (dev->quirks & PLX_LEGACY))
-               writel(BIT(FORCE_FULL_SPEED_MODE), &dev->usb->xcvrdiag);
-
-       /* ... then enable host detection and ep0; and we're ready
+       /* enable host detection and ep0; and we're ready
         * for set_configuration as well as eventual disconnect.
         */
        net2280_led_active(dev, 1);
@@ -2353,10 +2344,6 @@ static int net2280_stop(struct usb_gadget *_gadget)
 
        net2280_led_active(dev, 0);
 
-       /* Disable full-speed test mode */
-       if (dev->quirks & PLX_LEGACY)
-               writel(0, &dev->usb->xcvrdiag);
-
        device_remove_file(&dev->pdev->dev, &dev_attr_function);
        device_remove_file(&dev->pdev->dev, &dev_attr_queues);
 
@@ -3655,9 +3642,6 @@ static void net2280_shutdown(struct pci_dev *pdev)
        /* disable the pullup so the host will think we're gone */
        writel(0, &dev->usb->usbctl);
 
-       /* Disable full-speed test mode */
-       if (dev->quirks & PLX_LEGACY)
-               writel(0, &dev->usb->xcvrdiag);
 }