spi: sh-msiof: Fix transmit-only DMA transfers
authorGeert Uytterhoeven <geert+renesas@glider.be>
Thu, 7 Aug 2014 12:07:43 +0000 (14:07 +0200)
committerMark Brown <broonie@linaro.org>
Sat, 16 Aug 2014 22:14:30 +0000 (17:14 -0500)
Fix tx/rx mixup, which broke transmit-only transfers.

Introduced by commit 4240305f7cbdc7782aa8bc40cc702775d9ac0839
("spi: sh-msiof: Fix leaking of unused DMA descriptors").

Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/spi/spi-sh-msiof.c

index daaa868e959fccda3934783f7e6ef7e647528398..1165d418340f2c089af07a33c8a26ffa2c5c304f 100644 (file)
@@ -689,9 +689,9 @@ static int sh_msiof_dma_once(struct sh_msiof_spi_priv *p, const void *tx,
        reinit_completion(&p->done);
 
        /* Now start DMA */
-       if (tx)
-               dma_async_issue_pending(p->master->dma_rx);
        if (rx)
+               dma_async_issue_pending(p->master->dma_rx);
+       if (tx)
                dma_async_issue_pending(p->master->dma_tx);
 
        ret = sh_msiof_spi_start(p, rx);