GFS2: clean up explicit check for mandatory locks
authorPavel Emelyanov <xemul@openvz.org>
Mon, 1 Oct 2007 21:41:13 +0000 (14:41 -0700)
committerJ. Bruce Fields <bfields@citi.umich.edu>
Tue, 9 Oct 2007 22:32:46 +0000 (18:32 -0400)
The __mandatory_lock(inode) function makes the same check, but makes the code
more readable.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: Steven Whitehouse <swhiteho@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/gfs2/ops_file.c

index 94d76ace0b95b840427552c33636f3c0bab46fd3..28773cab4a3df1fa6d0f2c9aa2eb4f412c5b69a4 100644 (file)
@@ -535,7 +535,7 @@ static int gfs2_lock(struct file *file, int cmd, struct file_lock *fl)
 
        if (!(fl->fl_flags & FL_POSIX))
                return -ENOLCK;
-       if ((ip->i_inode.i_mode & (S_ISGID | S_IXGRP)) == S_ISGID)
+       if (__mandatory_lock(&ip->i_inode))
                return -ENOLCK;
 
        if (sdp->sd_args.ar_localflocks) {
@@ -637,7 +637,7 @@ static int gfs2_flock(struct file *file, int cmd, struct file_lock *fl)
 
        if (!(fl->fl_flags & FL_FLOCK))
                return -ENOLCK;
-       if ((ip->i_inode.i_mode & (S_ISGID | S_IXGRP)) == S_ISGID)
+       if (__mandatory_lock(&ip->i_inode))
                return -ENOLCK;
 
        if (sdp->sd_args.ar_localflocks)