projects
/
firefly-linux-kernel-4.4.55.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
dc6e69e
)
usb: gadget: function: delete an unnecessary check before rndis_add_hdr()
author
Markus Elfring
<elfring@users.sourceforge.net>
Fri, 21 Nov 2014 13:51:43 +0000
(14:51 +0100)
committer
Felipe Balbi
<balbi@ti.com>
Fri, 21 Nov 2014 15:08:12 +0000
(09:08 -0600)
The rndis_add_hdr() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/function/f_rndis.c
patch
|
blob
|
history
diff --git
a/drivers/usb/gadget/function/f_rndis.c
b/drivers/usb/gadget/function/f_rndis.c
index f13fc6a585652f4559d446a5dd009bf151a4d1b8..829edf878dac7aa184e1faa1a7891f5d2286faef 100644
(file)
--- a/
drivers/usb/gadget/function/f_rndis.c
+++ b/
drivers/usb/gadget/function/f_rndis.c
@@
-375,8
+375,7
@@
static struct sk_buff *rndis_add_header(struct gether *port,
struct sk_buff *skb2;
skb2 = skb_realloc_headroom(skb, sizeof(struct rndis_packet_msg_type));
- if (skb2)
- rndis_add_hdr(skb2);
+ rndis_add_hdr(skb2);
dev_kfree_skb(skb);
return skb2;