USB: iforce: remove err() usage
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Apr 2012 21:34:49 +0000 (14:34 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Apr 2012 21:34:49 +0000 (14:34 -0700)
err() was a very old USB-specific macro that I thought had gone away.
This patch removes it from being used in the driver and uses dev_err()
instead.

Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/input/joystick/iforce/iforce-main.c
drivers/input/joystick/iforce/iforce-packets.c
drivers/input/joystick/iforce/iforce-usb.c

index 405febd94f243539e4847475b9d4a37f6ffb0733..daeeb4c7e3b06dab2713fd1a4f656db69c0f1172 100644 (file)
@@ -317,7 +317,8 @@ int iforce_init_device(struct iforce *iforce)
                        break;
 
        if (i == 20) { /* 5 seconds */
-               err("Timeout waiting for response from device.");
+               dev_err(&input_dev->dev,
+                       "Timeout waiting for response from device.\n");
                error = -ENODEV;
                goto fail;
        }
index a17b50016009a5bfc9518d0728022f3c6db3a375..137326a5c2aa2d6655f38c0868a5f3721288bc71 100644 (file)
@@ -257,7 +257,8 @@ int iforce_get_id_packet(struct iforce *iforce, char *packet)
 
                status = usb_submit_urb(iforce->ctrl, GFP_ATOMIC);
                if (status) {
-                       err("usb_submit_urb failed %d", status);
+                       dev_err(&iforce->usbdev->dev,
+                               "usb_submit_urb failed %d\n", status);
                        return -1;
                }
 
@@ -289,12 +290,15 @@ int iforce_get_id_packet(struct iforce *iforce, char *packet)
                        return -1;
                }
 #else
-               err("iforce_get_id_packet: iforce->bus = SERIO!");
+               dev_err(&iforce->dev->dev,
+                       "iforce_get_id_packet: iforce->bus = SERIO!\n");
 #endif
                break;
 
        default:
-               err("iforce_get_id_packet: iforce->bus = %d", iforce->bus);
+               dev_err(&iforce->dev->dev,
+                       "iforce_get_id_packet: iforce->bus = %d\n",
+                       iforce->bus);
                break;
        }
 
index 6c96631ae5d9faff42fbe8e21969e78fca1133f4..ecbfae7d75392ac8fb2504358a98182ec81b0198 100644 (file)
@@ -100,8 +100,9 @@ static void iforce_usb_irq(struct urb *urb)
 exit:
        status = usb_submit_urb (urb, GFP_ATOMIC);
        if (status)
-               err ("%s - usb_submit_urb failed with result %d",
-                    __func__, status);
+               dev_err(&iforce->usbdev->dev,
+                       "%s - usb_submit_urb failed with result %d\n",
+                       __func__, status);
 }
 
 static void iforce_usb_out(struct urb *urb)