staging: comedi: usbduxfast: remove 'attached' from private data
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Tue, 14 May 2013 20:32:32 +0000 (13:32 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 May 2013 23:24:22 +0000 (16:24 -0700)
The subdevice function pointers are only setup if the device is
attached. The 'attached' flag in the private data is unnecessary.
Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/usbduxfast.c

index 3043024249813e85715df2211f75c2edcc63f480..59bbd4d94a2b24c1409e3a146442c0934b20e2c7 100644 (file)
@@ -148,7 +148,6 @@ static const struct comedi_lrange range_usbduxfast_ai_range = {
  * one sub device just now: A/D
  */
 struct usbduxfast_private {
-       int attached;           /* is attached? */
        struct usb_device *usb; /* pointer to the usb-device */
        struct urb *urbIn;      /* BULK-transfer handling: urb */
        int8_t *transfer_buffer;
@@ -276,11 +275,6 @@ static void usbduxfast_ai_interrupt(struct urb *urb)
                return;
        }
 
-       if (unlikely(!devpriv->attached)) {
-               /* no comedi device there */
-               return;
-       }
-
        /* first we test if something unusual has just happened */
        switch (urb->status) {
        case 0:
@@ -1246,8 +1240,6 @@ static int usbduxfast_attach_common(struct comedi_device *dev)
        s->maxdata      = 0x1000;
        s->range_table  = &range_usbduxfast_ai_range;
 
-       devpriv->attached = 1;
-
        up(&devpriv->sem);
 
        return 0;
@@ -1343,7 +1335,6 @@ static void usbduxfast_detach(struct comedi_device *dev)
 
        down(&devpriv->sem);
 
-       devpriv->attached = 0;
        devpriv->comedidev = NULL;
 
        if (devpriv->intf)