thunderbolt: Add casts to prevent endianness warnings
authorAndreas Noever <andreas.noever@gmail.com>
Fri, 20 Jun 2014 19:42:22 +0000 (21:42 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Jun 2014 20:06:01 +0000 (13:06 -0700)
Thunderbolt packets are big endian. Cast pkg->buffer to __be32* when
accessing the checksum.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Andreas Noever <andreas.noever@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/thunderbolt/ctl.c

index 4c6da92edcb4fb2e7a28c69bbd67211e859884cb..799634b382c6f0a131fb9eadd31dc89984f16830 100644 (file)
@@ -355,7 +355,7 @@ static int tb_ctl_tx(struct tb_ctl *ctl, void *data, size_t len,
        pkg->frame.sof = type;
        pkg->frame.eof = type;
        cpu_to_be32_array(pkg->buffer, data, len / 4);
-       *(u32 *) (pkg->buffer + len) = tb_crc(pkg->buffer, len);
+       *(__be32 *) (pkg->buffer + len) = tb_crc(pkg->buffer, len);
 
        res = ring_tx(ctl->tx, &pkg->frame);
        if (res) /* ring is stopped */
@@ -412,7 +412,7 @@ static void tb_ctl_rx_callback(struct tb_ring *ring, struct ring_frame *frame,
        }
 
        frame->size -= 4; /* remove checksum */
-       if (*(u32 *) (pkg->buffer + frame->size)
+       if (*(__be32 *) (pkg->buffer + frame->size)
                        != tb_crc(pkg->buffer, frame->size)) {
                tb_ctl_err(pkg->ctl,
                           "RX: checksum mismatch, dropping packet\n");