toshiba_acpi: Add keyboard backlight mode change event
authorAzael Avalos <coproscefalo@gmail.com>
Fri, 5 Dec 2014 03:22:47 +0000 (20:22 -0700)
committerDarren Hart <dvhart@linux.intel.com>
Wed, 3 Dec 2014 18:10:18 +0000 (10:10 -0800)
A previous patch added support to handle more events.

This patch adds support to update the sysfs group whenever we receive
a 0x92 event, which indicates a change in the keyboard backlight mode,
removing the update group code from toshiba_kbd_bl_mode_store, as it is
no longer needed there.

Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
drivers/platform/x86/toshiba_acpi.c

index 01e836987683f6df99c0c76af7f338ea307b123e..fc34a71866ed067624c2a851c29a182e9be48f08 100644 (file)
@@ -1394,12 +1394,6 @@ static ssize_t toshiba_kbd_bl_mode_store(struct device *dev,
                if (ret)
                        return ret;
 
-               /* Update sysfs entries on successful mode change*/
-               ret = sysfs_update_group(&toshiba->acpi_dev->dev.kobj,
-                                        &toshiba_attr_group);
-               if (ret)
-                       return ret;
-
                toshiba->kbd_mode = mode;
        }
 
@@ -2009,11 +2003,19 @@ error:
 static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event)
 {
        struct toshiba_acpi_dev *dev = acpi_driver_data(acpi_dev);
+       int ret;
 
        switch (event) {
        case 0x80: /* Hotkeys and some system events */
                toshiba_acpi_process_hotkeys(dev);
                break;
+       case 0x92: /* Keyboard backlight mode changed */
+               /* Update sysfs entries */
+               ret = sysfs_update_group(&acpi_dev->dev.kobj,
+                                        &toshiba_attr_group);
+               if (ret)
+                       pr_err("Unable to update sysfs entries\n");
+               break;
        case 0x81: /* Unknown */
        case 0x82: /* Unknown */
        case 0x83: /* Unknown */