staging: ozwpan: Fix coding style.
authorRupesh Gujare <rupesh.gujare@atmel.com>
Wed, 24 Jul 2013 14:06:46 +0000 (15:06 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jul 2013 20:40:53 +0000 (13:40 -0700)
This patch fixes coding style issues reported by Dan here:-
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2012-June/027767.html

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ozwpan/ozcdev.c

index 3e29760ba77e5a5614bab8ce440bc8a96e3b0c81..73b582cdf424a357fdb095e2468956f4c0096e7d 100644 (file)
@@ -333,10 +333,11 @@ int oz_cdev_register(void)
 {
        int err;
        struct device *dev;
+
        memset(&g_cdev, 0, sizeof(g_cdev));
        err = alloc_chrdev_region(&g_cdev.devnum, 0, 1, "ozwpan");
        if (err < 0)
-               goto out3;
+               return err;
        oz_dbg(ON, "Alloc dev number %d:%d\n",
               MAJOR(g_cdev.devnum), MINOR(g_cdev.devnum));
        cdev_init(&g_cdev.cdev, &oz_fops);
@@ -347,26 +348,26 @@ int oz_cdev_register(void)
        err = cdev_add(&g_cdev.cdev, g_cdev.devnum, 1);
        if (err < 0) {
                oz_dbg(ON, "Failed to add cdev\n");
-               goto out2;
+               goto unregister;
        }
        g_oz_class = class_create(THIS_MODULE, "ozmo_wpan");
        if (IS_ERR(g_oz_class)) {
                oz_dbg(ON, "Failed to register ozmo_wpan class\n");
                err = PTR_ERR(g_oz_class);
-               goto out1;
+               goto delete;
        }
        dev = device_create(g_oz_class, NULL, g_cdev.devnum, NULL, "ozwpan");
        if (IS_ERR(dev)) {
                oz_dbg(ON, "Failed to create sysfs entry for cdev\n");
                err = PTR_ERR(dev);
-               goto out1;
+               goto delete;
        }
        return 0;
-out1:
+
+delete:
        cdev_del(&g_cdev.cdev);
-out2:
+unregister:
        unregister_chrdev_region(g_cdev.devnum, 1);
-out3:
        return err;
 }
 /*------------------------------------------------------------------------------