Staging: batman-adv: Don't inform about dropped packets in nodebug
authorSven Eckelmann <sven.eckelmann@gmx.de>
Sat, 4 Sep 2010 23:58:37 +0000 (01:58 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sun, 5 Sep 2010 07:29:50 +0000 (00:29 -0700)
Information about dropped packets are usually only interesting for
debugging purposes and otherwise open the possibility to flood the logs
of the target machine with useless information.

pr_debug will not output those information on a nodebug kernel.

Reported-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/batman-adv/routing.c
drivers/staging/batman-adv/vis.c

index eda08b5efb0282144284ede0cc0b0addea4935a2..e12fd995417c5e43f32eba8a6af2b7ed24fd30d3 100644 (file)
@@ -859,9 +859,9 @@ static int recv_icmp_ttl_exceeded(struct bat_priv *bat_priv,
 
        /* send TTL exceeded if packet is an echo request (traceroute) */
        if (icmp_packet->msg_type != ECHO_REQUEST) {
-               pr_warning("Warning - can't forward icmp packet from %pM to "
-                          "%pM: ttl exceeded\n", icmp_packet->orig,
-                          icmp_packet->dst);
+               pr_debug("Warning - can't forward icmp packet from %pM to "
+                        "%pM: ttl exceeded\n", icmp_packet->orig,
+                        icmp_packet->dst);
                return NET_RX_DROP;
        }
 
@@ -1141,9 +1141,9 @@ static int route_unicast_packet(struct sk_buff *skb,
 
        /* TTL exceeded */
        if (unicast_packet->ttl < 2) {
-               pr_warning("Warning - can't forward unicast packet from %pM to "
-                          "%pM: ttl exceeded\n", ethhdr->h_source,
-                          unicast_packet->dest);
+               pr_debug("Warning - can't forward unicast packet from %pM to "
+                        "%pM: ttl exceeded\n", ethhdr->h_source,
+                        unicast_packet->dest);
                return NET_RX_DROP;
        }
 
@@ -1224,8 +1224,7 @@ int recv_ucast_frag_packet(struct sk_buff *skb, struct batman_if *recv_if)
                        hash_find(bat_priv->orig_hash, unicast_packet->orig));
 
                if (!orig_node) {
-                       pr_warning("couldn't find orig node for "
-                               "fragmentation\n");
+                       pr_debug("couldn't find orig node for fragmentation\n");
                        spin_unlock_irqrestore(&bat_priv->orig_hash_lock,
                                               flags);
                        return NET_RX_DROP;
index 071d3b7c4ea9d505326f1e11e6bf4acb55df1795..b2cec8e289693441e5a9354ec1754d52cb4296c8 100644 (file)
@@ -745,7 +745,7 @@ static void send_vis_packet(struct bat_priv *bat_priv, struct vis_info *info)
 
        packet = (struct vis_packet *)info->skb_packet->data;
        if (packet->ttl < 2) {
-               pr_warning("Error - can't send vis packet: ttl exceeded\n");
+               pr_debug("Error - can't send vis packet: ttl exceeded\n");
                return;
        }