ALSA: dice: suppress checkpatch.pl warnings
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Fri, 28 Nov 2014 15:59:10 +0000 (00:59 +0900)
committerTakashi Iwai <tiwai@suse.de>
Sat, 29 Nov 2014 19:02:48 +0000 (20:02 +0100)
The checkpatch.pl generates some warnings due to:
 - C99 comment
 - a line over 80 characters
 - min() for parameters with different types

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/dice.c

index e3a04d69c85363dfffdc6bebf5400b95cff401fa..72af110d0f9838645be617b1d5627bf40e3dbcea 100644 (file)
@@ -133,7 +133,7 @@ static inline u64 global_address(struct dice *dice, unsigned int offset)
        return DICE_PRIVATE_SPACE + dice->global_offset + offset;
 }
 
-// TODO: rx index
+/* TODO: rx index */
 static inline u64 rx_address(struct dice *dice, unsigned int offset)
 {
        return DICE_PRIVATE_SPACE + dice->rx_offset + offset;
@@ -721,13 +721,14 @@ static long dice_hwdep_read(struct snd_hwdep *hwdep, char __user *buf,
                event.lock_status.status = dice->dev_lock_count > 0;
                dice->dev_lock_changed = false;
 
-               count = min(count, (long)sizeof(event.lock_status));
+               count = min_t(long, count, sizeof(event.lock_status));
        } else {
-               event.dice_notification.type = SNDRV_FIREWIRE_EVENT_DICE_NOTIFICATION;
+               event.dice_notification.type =
+                                       SNDRV_FIREWIRE_EVENT_DICE_NOTIFICATION;
                event.dice_notification.notification = dice->notification_bits;
                dice->notification_bits = 0;
 
-               count = min(count, (long)sizeof(event.dice_notification));
+               count = min_t(long, count, sizeof(event.dice_notification));
        }
 
        spin_unlock_irq(&dice->lock);