staging: et131x: Reduce indenting in et131x_rx_dma_memory_free()
authorMark Einon <mark.einon@gmail.com>
Fri, 16 Nov 2012 10:47:39 +0000 (10:47 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Nov 2012 21:57:27 +0000 (13:57 -0800)
This change negates an 'if' statement, allowing a large block of code
to be un-indented, making the code more readable.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/et131x/et131x.c

index c411d13baa26ea9eb9268211d6c4c675d5523cd1..9ccd9b7f2fbe8613c7d2180197d8fd4e9433c825 100644 (file)
@@ -2443,33 +2443,33 @@ static void et131x_rx_dma_memory_free(struct et131x_adapter *adapter)
 
        /* Free Free Buffer Rings */
        for (id = 0; id < NUM_FBRS; id++) {
-               if (rx_ring->fbr[id]->ring_virtaddr) {
-                       /* First the packet memory */
-                       for (index = 0; index <
-                               (rx_ring->fbr[id]->num_entries / FBR_CHUNKS);
-                            index++) {
-                               if (rx_ring->fbr[id]->mem_virtaddrs[index]) {
+               if (!rx_ring->fbr[id]->ring_virtaddr)
+                       continue;
 
-                                       bufsize = (rx_ring->fbr[id]->buffsize * FBR_CHUNKS);
+               /* First the packet memory */
+               for (index = 0;
+                    index < (rx_ring->fbr[id]->num_entries / FBR_CHUNKS);
+                    index++) {
+                       if (rx_ring->fbr[id]->mem_virtaddrs[index]) {
+                               bufsize = rx_ring->fbr[id]->buffsize * FBR_CHUNKS;
 
-                                       dma_free_coherent(&adapter->pdev->dev,
-                                               bufsize,
-                                               rx_ring->fbr[id]->mem_virtaddrs[index],
-                                               rx_ring->fbr[id]->mem_physaddrs[index]);
+                               dma_free_coherent(&adapter->pdev->dev,
+                                       bufsize,
+                                       rx_ring->fbr[id]->mem_virtaddrs[index],
+                                       rx_ring->fbr[id]->mem_physaddrs[index]);
 
-                                       rx_ring->fbr[id]->mem_virtaddrs[index] = NULL;
-                               }
+                               rx_ring->fbr[id]->mem_virtaddrs[index] = NULL;
                        }
+               }
 
-                       bufsize =
-                           sizeof(struct fbr_desc) * rx_ring->fbr[id]->num_entries;
+               bufsize =
+                   sizeof(struct fbr_desc) * rx_ring->fbr[id]->num_entries;
 
-                       dma_free_coherent(&adapter->pdev->dev, bufsize,
-                                           rx_ring->fbr[id]->ring_virtaddr,
-                                           rx_ring->fbr[id]->ring_physaddr);
+               dma_free_coherent(&adapter->pdev->dev, bufsize,
+                                   rx_ring->fbr[id]->ring_virtaddr,
+                                   rx_ring->fbr[id]->ring_physaddr);
 
-                       rx_ring->fbr[id]->ring_virtaddr = NULL;
-               }
+               rx_ring->fbr[id]->ring_virtaddr = NULL;
        }
 
        /* Free Packet Status Ring */