iio: dac: ad5624r_spi: Don't set error code to voltage_uv
authorAxel Lin <axel.lin@ingics.com>
Fri, 14 Dec 2012 12:07:00 +0000 (12:07 +0000)
committerJonathan Cameron <jic23@kernel.org>
Thu, 27 Dec 2012 11:00:19 +0000 (11:00 +0000)
regulator_get_voltage() may return negative error code.
Add error checking to avoid setting error code to voltage_uv.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/dac/ad5624r_spi.c

index 6a7d6a48cc6ddf0d57969822a1bab28e9c8b8400..14ea3dbf490222b4582496a0a93f232a6cb7cc25 100644 (file)
@@ -238,7 +238,11 @@ static int __devinit ad5624r_probe(struct spi_device *spi)
                if (ret)
                        goto error_put_reg;
 
-               voltage_uv = regulator_get_voltage(st->reg);
+               ret = regulator_get_voltage(st->reg);
+               if (ret < 0)
+                       goto error_disable_reg;
+
+               voltage_uv = ret;
        }
 
        spi_set_drvdata(spi, indio_dev);