microblaze: Remove __ARCH_WANT_INTERRUPTS_ON_CTXSW usage
authorPeter Zijlstra <peterz@infradead.org>
Wed, 24 Aug 2011 13:32:31 +0000 (15:32 +0200)
committerMichal Simek <monstr@monstr.eu>
Fri, 14 Oct 2011 10:28:42 +0000 (12:28 +0200)
As far as I can tell the only reason microblaze has
__ARCH_WANT_INTERRUPTS_ON_CTXSW is because it initializes new task state
with interrupts enabled so that on switch_to() interrupts get enabled.

So change copy_thread() to clear MSR_IE instead of set it, this will
ensure switch_to() will always keep IRQs disabled.

The scheduler will disable IRQs when taking rq->lock in schedule() and
enable IRQs in finish_lock_switch() after its done its magic.

This leaves ARM the only __ARCH_WANT_INTERRUPTS_ON_CTXSW user.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Michal Simek <monstr@monstr.eu>
arch/microblaze/include/asm/system.h
arch/microblaze/kernel/process.c

index 0953d1425d5b3130db47019959cad56b1fac7613..5a433cbaafb3296f1c9df2239e9b4ed513b95418 100644 (file)
@@ -17,8 +17,6 @@
 #include <asm-generic/cmpxchg.h>
 #include <asm-generic/cmpxchg-local.h>
 
-#define __ARCH_WANT_INTERRUPTS_ON_CTXSW
-
 struct task_struct;
 struct thread_info;
 
index dbb812421d8a15629dd051cd931aea24c625c58f..95cc295976a73279878ddd103aeb6777c263c9a6 100644 (file)
@@ -179,6 +179,7 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,
 
        ti->cpu_context.msr = (childregs->msr|MSR_VM);
        ti->cpu_context.msr &= ~MSR_UMS; /* switch_to to kernel mode */
+       ti->cpu_context.msr &= ~MSR_IE;
 #endif
        ti->cpu_context.r15 = (unsigned long)ret_from_fork - 8;