[EBTABLES]: Fix thinkos in ebt_log.c
authorDavid S. Miller <davem@davemloft.net>
Tue, 28 Jun 2005 19:39:40 +0000 (12:39 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 28 Jun 2005 19:39:40 +0000 (12:39 -0700)
When converting over the skb_header_pointer(), I converted parts of
this module incorrectly.  Kill the 'u' union in ebt_log() and all the
bogus references to it.

Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/netfilter/ebt_log.c

index e4ae34b889251890ee8a018c41e6a0299a085369..662975be3d1d1aaef6f20aecccbb9a01128cace1 100644 (file)
@@ -61,8 +61,6 @@ static void ebt_log(const struct sk_buff *skb, unsigned int hooknr,
 {
        struct ebt_log_info *info = (struct ebt_log_info *)data;
        char level_string[4] = "< >";
-       union {struct iphdr iph; struct tcpudphdr ports;
-              struct arphdr arph; struct arppayload arpp;} u;
 
        level_string[1] = '0' + info->loglevel;
        spin_lock_bh(&ebt_log_lock);
@@ -88,7 +86,7 @@ static void ebt_log(const struct sk_buff *skb, unsigned int hooknr,
                }
                printk(" IP SRC=%u.%u.%u.%u IP DST=%u.%u.%u.%u,",
                   NIPQUAD(ih->saddr), NIPQUAD(ih->daddr));
-               printk(" IP tos=0x%02X, IP proto=%d", u.iph.tos,
+               printk(" IP tos=0x%02X, IP proto=%d", ih->tos,
                       ih->protocol);
                if (ih->protocol == IPPROTO_TCP ||
                    ih->protocol == IPPROTO_UDP) {
@@ -127,7 +125,7 @@ static void ebt_log(const struct sk_buff *skb, unsigned int hooknr,
                    ah->ar_pln == sizeof(uint32_t)) {
                        struct arppayload _arpp, *ap;
 
-                       ap = skb_header_pointer(skb, sizeof(u.arph),
+                       ap = skb_header_pointer(skb, sizeof(_arph),
                                                sizeof(_arpp), &_arpp);
                        if (ap == NULL) {
                                printk(" INCOMPLETE ARP payload");