[media] drivers/media: fix dependencies in video mt9t001/mt9p031
authorPaul Gortmaker <paul.gortmaker@windriver.com>
Fri, 30 Sep 2011 20:34:51 +0000 (17:34 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 8 Oct 2011 11:01:46 +0000 (08:01 -0300)
Both mt9t001.c and mt9p031.c have two identical issues, those
being that they will need module.h inclusion for the upcoming
cleanup going on there, and that their dependencies don't limit
selection of configs that will fail to compile as follows:

The related config options are CONFIG_MEDIA_CONTROLLER and
CONFIG_VIDEO_V4L2_SUBDEV_API.  Looking at the code, it appears
that the driver was never intended to work without these enabled,
so add a dependency on CONFIG_VIDEO_V4L2_SUBDEV_API, which in
turn already has a dependency on CONFIG_MEDIA_CONTROLLER.

Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/Kconfig
drivers/media/video/mt9p031.c
drivers/media/video/mt9t001.c

index aed5b3d740ca0160f7ae500e52f60ca754cf7388..b80bea26af62c3d1fa06520260735c7131a74f1f 100644 (file)
@@ -469,14 +469,14 @@ config VIDEO_OV7670
 
 config VIDEO_MT9P031
        tristate "Aptina MT9P031 support"
-       depends on I2C && VIDEO_V4L2
+       depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
        ---help---
          This is a Video4Linux2 sensor-level driver for the Aptina
          (Micron) mt9p031 5 Mpixel camera.
 
 config VIDEO_MT9T001
        tristate "Aptina MT9T001 support"
-       depends on I2C && VIDEO_V4L2
+       depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
        ---help---
          This is a Video4Linux2 sensor-level driver for the Aptina
          (Micron) mt0t001 3 Mpixel camera.
index 5cfa39f4bf141742734bdb499e87f4f9cd710361..73c068993f050cce24eb408d2cbf7e745791c667 100644 (file)
@@ -14,6 +14,7 @@
 
 #include <linux/delay.h>
 #include <linux/device.h>
+#include <linux/module.h>
 #include <linux/i2c.h>
 #include <linux/log2.h>
 #include <linux/pm.h>
index cac14160b5c36578c822d97a146c132767c7df66..08074b8a2736ca75a8bcdd6a26512536e584cf36 100644 (file)
@@ -13,6 +13,7 @@
  */
 
 #include <linux/i2c.h>
+#include <linux/module.h>
 #include <linux/log2.h>
 #include <linux/slab.h>
 #include <linux/videodev2.h>