sysv: remove unnecessary dentry_unhash from rmdir, dir rename
authorSage Weil <sage@newdream.net>
Fri, 27 May 2011 20:41:55 +0000 (13:41 -0700)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 28 May 2011 05:02:50 +0000 (01:02 -0400)
sysv does not have problems with references to unlinked directories.

CC: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/sysv/namei.c

index e2cc6756f3b1595600d8ae25f537b4e1b0b19855..e474fbcf8bde991924da62e321d2be7eae8ac5f6 100644 (file)
@@ -196,8 +196,6 @@ static int sysv_rmdir(struct inode * dir, struct dentry * dentry)
        struct inode *inode = dentry->d_inode;
        int err = -ENOTEMPTY;
 
-       dentry_unhash(dentry);
-
        if (sysv_empty_dir(inode)) {
                err = sysv_unlink(dir, dentry);
                if (!err) {
@@ -224,9 +222,6 @@ static int sysv_rename(struct inode * old_dir, struct dentry * old_dentry,
        struct sysv_dir_entry * old_de;
        int err = -ENOENT;
 
-       if (new_inode && S_ISDIR(new_inode->i_mode))
-               dentry_unhash(new_dentry);
-
        old_de = sysv_find_entry(old_dentry, &old_page);
        if (!old_de)
                goto out;