dma: mv_xor: Remove unneeded mv_xor_clean_completed_slots() call
authorEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Fri, 7 Mar 2014 19:46:45 +0000 (16:46 -0300)
committerDan Williams <dan.j.williams@intel.com>
Thu, 10 Apr 2014 19:26:17 +0000 (12:26 -0700)
In mv_xor_status(), we are currently calling mv_xor_clean_completed_slots()
when the transaction is complete (the cookie status is DMA_COMPLETE).
However, a completed status means that mv_xor_slot_cleanup() was called,
which cleans the completed slots.

In other words, there's nothing to cleanup for a completed transaction in
mv_xor_status(). Remove the unneeded call to mv_xor_clean_completed_slots().

Reported-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/dma/mv_xor.c

index e70f271c99fa812771921ace6346abd39e83888a..e2c8ec91155e8a11eae418a222dc455ffbbe33b3 100644 (file)
@@ -702,10 +702,8 @@ static enum dma_status mv_xor_status(struct dma_chan *chan,
        enum dma_status ret;
 
        ret = dma_cookie_status(chan, cookie, txstate);
-       if (ret == DMA_COMPLETE) {
-               mv_xor_clean_completed_slots(mv_chan);
+       if (ret == DMA_COMPLETE)
                return ret;
-       }
        mv_xor_slot_cleanup(mv_chan);
 
        return dma_cookie_status(chan, cookie, txstate);