nubus: Don't use create_proc_entry()
authorDavid Howells <dhowells@redhat.com>
Thu, 4 Apr 2013 15:44:51 +0000 (16:44 +0100)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 9 Apr 2013 18:16:38 +0000 (14:16 -0400)
Don't use create_proc_entry() in nubus_proc_subdir().  The files created aren't
given any way to use them, so for the moment use create_proc_read_entry() with
a NULL accessor and generate a compile-time warning.

Signed-off-by: David Howells <dhowells@redhat.com>
drivers/nubus/proc.c

index 208dd12825bc4314be4bbba70a9c898d8b99ae92..bb1446bb28027fe246f880025e2c9d812fb46165 100644 (file)
@@ -73,8 +73,9 @@ static void nubus_proc_subdir(struct nubus_dev* dev,
                struct proc_dir_entry* e;
                
                sprintf(name, "%x", ent.type);
-               e = create_proc_entry(name, S_IFREG | S_IRUGO |
-                                     S_IWUSR, parent);
+#warning Need to set some I/O handlers here
+               e = create_proc_read_entry(name, S_IFREG | S_IRUGO | S_IWUSR,
+                                          parent, NULL, NULL);
                if (!e) return;
        }
 }