[SCSI] qla2xxx: handle default case in qla2x00_request_firmware()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 21 Feb 2012 07:29:40 +0000 (10:29 +0300)
committerJames Bottomley <JBottomley@Parallels.com>
Wed, 29 Feb 2012 22:47:13 +0000 (16:47 -0600)
This silences a static checker warning.  Also we're always adding new
types of firmware, so it might fix a bug in real life some day.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Chad Dupuis <chad.dupuis@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/qla2xxx/qla_os.c

index 094af74989d6117e4a0a9ab45d85ee7f22eaa62e..a2f999273a5fa5e9d9a2a3328df54524b1b5fe75 100644 (file)
@@ -4058,7 +4058,6 @@ qla2x00_request_firmware(scsi_qla_host_t *vha)
        struct qla_hw_data *ha = vha->hw;
        struct fw_blob *blob;
 
-       blob = NULL;
        if (IS_QLA2100(ha)) {
                blob = &qla_fw_blobs[FW_ISP21XX];
        } else if (IS_QLA2200(ha)) {
@@ -4079,6 +4078,8 @@ qla2x00_request_firmware(scsi_qla_host_t *vha)
                blob = &qla_fw_blobs[FW_ISP2031];
        } else if (IS_QLA8031(ha)) {
                blob = &qla_fw_blobs[FW_ISP8031];
+       } else {
+               return NULL;
        }
 
        mutex_lock(&qla_fw_lock);