sata_mv remove redundant edma init code
authorMark Lord <liml@rtr.ca>
Wed, 16 Apr 2008 19:00:17 +0000 (15:00 -0400)
committerJeff Garzik <jgarzik@redhat.com>
Thu, 17 Apr 2008 19:56:21 +0000 (15:56 -0400)
Remove unnecessary edma init code from port_start.
This sequence gets done later on the first I/O to the port.

Signed-off-by: Mark Lord <mlord@pobox.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/sata_mv.c

index b822b8a40c65cd6252543ed198e2c420eac9ff59..82632e7e34f0786d4301f973e8863d7ae996a89e 100644 (file)
@@ -1144,8 +1144,6 @@ static int mv_port_start(struct ata_port *ap)
        struct device *dev = ap->host->dev;
        struct mv_host_priv *hpriv = ap->host->private_data;
        struct mv_port_priv *pp;
-       void __iomem *port_mmio = mv_ap_base(ap);
-       unsigned long flags;
        int tag;
 
        pp = devm_kzalloc(dev, sizeof(*pp), GFP_KERNEL);
@@ -1178,18 +1176,6 @@ static int mv_port_start(struct ata_port *ap)
                        pp->sg_tbl_dma[tag] = pp->sg_tbl_dma[0];
                }
        }
-
-       spin_lock_irqsave(&ap->host->lock, flags);
-
-       mv_edma_cfg(ap, 0);
-       mv_set_edma_ptrs(port_mmio, hpriv, pp);
-
-       spin_unlock_irqrestore(&ap->host->lock, flags);
-
-       /* Don't turn on EDMA here...do it before DMA commands only.  Else
-        * we'll be unable to send non-data, PIO, etc due to restricted access
-        * to shadow regs.
-        */
        return 0;
 
 out_port_free_dma_mem: