ARM: hw_breakpoint: Enable debug powerdown only if system supports 'has_ossr'
authorLokesh Vutla <lokeshvutla@ti.com>
Wed, 13 Mar 2013 06:52:33 +0000 (06:52 +0000)
committerJon Medhurst <tixy@linaro.org>
Wed, 17 Jul 2013 10:12:14 +0000 (11:12 +0100)
Commit {9a6eb31 ARM: hw_breakpoint: Debug powerdown support for self-hosted
debug} introduces debug powerdown support for self-hosted debug.
While merging the patch 'has_ossr' check was removed which
was needed for hardwares which doesn't support self-hosted debug.
Pandaboard (A9) is one such hardware and Dietmar's orginial
patch did mention this issue.
Without that check on Panda with CPUIDLE enabled, a flood of
below messages thrown.

[ 3.597930] hw-breakpoint: CPU 0 failed to disable vector catch
[ 3.597991] hw-breakpoint: CPU 1 failed to disable vector catch

So restore that check back to avoid the mentioned issue.

Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Reported-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
arch/arm/kernel/hw_breakpoint.c

index 1fd749ee4a1bb96c1740f4a131fde1d3cd53bfb0..1b803117ed91c212a6f4077d6c87b58c0e219f44 100644 (file)
@@ -1049,7 +1049,8 @@ static struct notifier_block dbg_cpu_pm_nb = {
 
 static void __init pm_init(void)
 {
-       cpu_pm_register_notifier(&dbg_cpu_pm_nb);
+       if (has_ossr)
+               cpu_pm_register_notifier(&dbg_cpu_pm_nb);
 }
 #else
 static inline void pm_init(void)