wl12xx: Reorder data handling in irq_work
authorIdo Yariv <ido@wizery.com>
Tue, 1 Mar 2011 13:14:38 +0000 (15:14 +0200)
committerLuciano Coelho <coelho@ti.com>
Thu, 3 Mar 2011 14:10:46 +0000 (16:10 +0200)
The FW has a limited amount of memory for holding frames. In case it
runs out of memory reserved for RX frames, it'll have no other choice
but to drop packets received from the AP. Thus, it is important to
handle RX data interrupts as soon as possible, before handling anything
else.

In addition, since there are enough TX descriptors to go around, it is
better to first send TX frames, and only then handle TX completions.

Fix this by changing the order of function calls in wl1271_irq_work.

Signed-off-by: Ido Yariv <ido@wizery.com>
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
Reviewed-by: Luciano Coelho <coelho@ti.com>
Signed-off-by: Luciano Coelho <coelho@ti.com>
drivers/net/wireless/wl12xx/main.c

index 947491a1d9cc718fbad166353106bfabfd8e270b..65e8a0cc92d058d73206183ae697b7f7825df404 100644 (file)
@@ -685,10 +685,7 @@ static void wl1271_irq_work(struct work_struct *work)
                if (intr & WL1271_ACX_INTR_DATA) {
                        wl1271_debug(DEBUG_IRQ, "WL1271_ACX_INTR_DATA");
 
-                       /* check for tx results */
-                       if (wl->fw_status->common.tx_results_counter !=
-                           (wl->tx_results_count & 0xff))
-                               wl1271_tx_complete(wl);
+                       wl1271_rx(wl, &wl->fw_status->common);
 
                        /* Check if any tx blocks were freed */
                        if (!test_bit(WL1271_FLAG_FW_TX_BUSY, &wl->flags) &&
@@ -700,7 +697,10 @@ static void wl1271_irq_work(struct work_struct *work)
                                wl1271_tx_work_locked(wl);
                        }
 
-                       wl1271_rx(wl, &wl->fw_status->common);
+                       /* check for tx results */
+                       if (wl->fw_status->common.tx_results_counter !=
+                           (wl->tx_results_count & 0xff))
+                               wl1271_tx_complete(wl);
                }
 
                if (intr & WL1271_ACX_INTR_EVENT_A) {