Revert "[lit] Speculatively fix PR24554 by manually closing the process handle"
authorReid Kleckner <rnk@google.com>
Mon, 31 Aug 2015 21:42:02 +0000 (21:42 +0000)
committerReid Kleckner <rnk@google.com>
Mon, 31 Aug 2015 21:42:02 +0000 (21:42 +0000)
This reverts commit r245946. It didn't help the problem:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/9179/steps/run%20tests/logs/stdio
LINK : fatal error LNK1104: cannot open file

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@246491 91177308-0d34-0410-b5e6-96231b3b80d8

utils/lit/lit/TestRunner.py

index 1fa43b394f72c0ba7653255a3206f92bd51198f3..055a282f3bca11902d0a1a793746b6cc3f77f465 100644 (file)
@@ -257,9 +257,6 @@ def executeShCmd(cmd, shenv, results):
     exitCode = None
     for i,(out,err) in enumerate(procData):
         res = procs[i].wait()
-        # On Windows, manually close the process handles.
-        if kIsWindows:
-            procs[i]._handle.Close()
         # Detect Ctrl-C in subprocess.
         if res == -signal.SIGINT:
             raise KeyboardInterrupt