HID: primax: Remove px_probe() and px_remove() functions
authorAxel Lin <axel.lin@gmail.com>
Fri, 7 Sep 2012 07:11:50 +0000 (15:11 +0800)
committerJiri Kosina <jkosina@suse.cz>
Fri, 7 Sep 2012 12:55:38 +0000 (14:55 +0200)
The px_probe() and px_remove() functions do not have any special initialization
and cleanup. Remove them and let HID core handle the default probe/remove
actions.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-primax.c

index 4d3c60d883183833fde0ed829197793a1db7b2c1..c15adb0c98a1d9a74475988360bc0182f63462e6 100644 (file)
@@ -64,29 +64,6 @@ static int px_raw_event(struct hid_device *hid, struct hid_report *report,
        return 0;
 }
 
-static int px_probe(struct hid_device *hid, const struct hid_device_id *id)
-{
-       int ret;
-
-       ret = hid_parse(hid);
-       if (ret) {
-               hid_err(hid, "parse failed\n");
-               goto fail;
-       }
-
-       ret = hid_hw_start(hid, HID_CONNECT_DEFAULT);
-       if (ret)
-               hid_err(hid, "hw start failed\n");
-
-fail:
-       return ret;
-}
-
-static void px_remove(struct hid_device *hid)
-{
-       hid_hw_stop(hid);
-}
-
 static const struct hid_device_id px_devices[] = {
        { HID_USB_DEVICE(USB_VENDOR_ID_PRIMAX, USB_DEVICE_ID_PRIMAX_KEYBOARD) },
        { }
@@ -97,8 +74,6 @@ static struct hid_driver px_driver = {
        .name = "primax",
        .id_table = px_devices,
        .raw_event = px_raw_event,
-       .probe = px_probe,
-       .remove = px_remove,
 };
 
 static int __init px_init(void)