Rewrite DIExpression::printInternal() to use the iterator interface.
authorAdrian Prantl <aprantl@apple.com>
Thu, 22 Jan 2015 16:55:22 +0000 (16:55 +0000)
committerAdrian Prantl <aprantl@apple.com>
Thu, 22 Jan 2015 16:55:22 +0000 (16:55 +0000)
NFC.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@226836 91177308-0d34-0410-b5e6-96231b3b80d8

lib/IR/DebugInfo.cpp

index da77c9bb6f98a668d466f6c1c532710756ec0b6c..4a7bc67ab58f93ef2e6e6ac9b06516e4603d7c1d 100644 (file)
@@ -1406,27 +1406,23 @@ void DIVariable::printInternal(raw_ostream &OS) const {
 }
 
 void DIExpression::printInternal(raw_ostream &OS) const {
-  for (unsigned I = 0; I < getNumElements(); ++I) {
-    uint64_t OpCode = getElement(I);
+  for (auto E = end(), I = begin(); I != E; ++I) {
+    uint64_t OpCode = *I;
     OS << " [" << OperationEncodingString(OpCode);
     switch (OpCode) {
     case DW_OP_plus: {
-      OS << " " << getElement(++I);
+      OS << " " << I.getArg(1);
       break;
     }
     case DW_OP_piece: {
-      unsigned Offset = getElement(++I);
-      unsigned Size = getElement(++I);
-      OS << " offset=" << Offset << ", size=" << Size;
+      OS << " offset=" << I.getArg(1) << ", size=" << I.getArg(2);
       break;
     }
     case DW_OP_deref:
       // No arguments.
       break;
     default:
-      // Else bail out early. This may be a line table entry.
-      OS << "Unknown]";
-      return;
+      llvm_unreachable("unhandled operation");
     }
     OS << "]";
   }