perf tools: Use memdup in map__clone
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 25 Jan 2013 01:16:43 +0000 (22:16 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 25 Jan 2013 15:49:28 +0000 (12:49 -0300)
We have memdup() exactly for that, remove open coded dup.

Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-tnsoexrgv6u9l125srq2c7su@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/map.c

index b6b163642c7d1188c152d182fdcdbf1247674be6..6fcb9de623401b8ac731c3c240eb1cd5863683f4 100644 (file)
@@ -11,6 +11,7 @@
 #include "strlist.h"
 #include "vdso.h"
 #include "build-id.h"
+#include <linux/string.h>
 
 const char *map_type__name[MAP__NR_TYPES] = {
        [MAP__FUNCTION] = "Functions",
@@ -213,12 +214,7 @@ struct symbol *map__find_symbol_by_name(struct map *map, const char *name,
 
 struct map *map__clone(struct map *map)
 {
-       struct map *clone = malloc(sizeof(*clone));
-
-       if (clone != NULL)
-               memcpy(clone, map, sizeof(*clone));
-
-       return clone;
+       return memdup(map, sizeof(*map));
 }
 
 int map__overlap(struct map *l, struct map *r)