[media] xc4000: removed redundant tuner reset
authorIstvan Varga <istvan_v@mailbox.hu>
Sat, 4 Jun 2011 15:21:17 +0000 (12:21 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 27 Jul 2011 20:52:39 +0000 (17:52 -0300)
This patch causes the tuner reset command to be ignored in the firmware
code, since this only happens when the BASE/INIT1 firmware is loaded by
check_firmware(), and in that case check_firmware() already calls the
reset callback before starting to load the firmware.

Signed-off-by: Istvan Varga <istvan_v@mailbox.hu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/common/tuners/xc4000.c

index c3e564e9f8ca467dccfe6232fb03ff41dce1da8c..b04c73bab83cbd8093280c9260e0ab250fe3b0c4 100644 (file)
@@ -338,10 +338,12 @@ static int xc_load_i2c_sequence(struct dvb_frontend *fe, const u8 *i2c_sequence)
                len = i2c_sequence[index] * 256 + i2c_sequence[index+1];
                if (len == 0x0000) {
                        /* RESET command */
-                       result = xc4000_TunerReset(fe);
                        index += 2;
+#if 0                  /* not needed, as already called by check_firmware() */
+                       result = xc4000_TunerReset(fe);
                        if (result != XC_RESULT_SUCCESS)
                                return result;
+#endif
                } else if (len & 0x8000) {
                        /* WAIT command */
                        xc_wait(len & 0x7FFF);