xen-netback: Disable NAPI after disabling interrupts
authorZoltan Kiss <zoltan.kiss@linaro.org>
Tue, 28 Oct 2014 15:29:30 +0000 (15:29 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 29 Oct 2014 19:59:37 +0000 (15:59 -0400)
Otherwise the interrupt handler still calls napi_complete. Although it
won't schedule NAPI again as either NAPI_STATE_DISABLE or
NAPI_STATE_SCHED is set, it is just unnecessary, and it makes more
sense to do this way.

Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/xen-netback/interface.c

index f379689dde309b7bf63eb511ef7f28a827f71fc5..7342a6bb5557c21e46ee8b1b4a01c635d405b15f 100644 (file)
@@ -281,10 +281,10 @@ static void xenvif_down(struct xenvif *vif)
 
        for (queue_index = 0; queue_index < num_queues; ++queue_index) {
                queue = &vif->queues[queue_index];
-               napi_disable(&queue->napi);
                disable_irq(queue->tx_irq);
                if (queue->tx_irq != queue->rx_irq)
                        disable_irq(queue->rx_irq);
+               napi_disable(&queue->napi);
                del_timer_sync(&queue->credit_timeout);
        }
 }