genirq: Add missing break in __irq_set_trigger()
authorThomas Gleixner <tglx@linutronix.de>
Mon, 21 Feb 2011 13:19:42 +0000 (14:19 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 21 Feb 2011 20:20:00 +0000 (21:20 +0100)
The switch case in __irq_set_trigger() lacks a break, which emits a
pr_err unconditionally on success.

Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/irq/manage.c

index 6cca1956c503fc9ce1d3f94927abbbb6fb2ad763..01f8a9519e63722a07a2de13edf3d4f3c18dd3d3 100644 (file)
@@ -567,6 +567,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq,
                if (chip != desc->irq_data.chip)
                        irq_chip_set_defaults(desc->irq_data.chip);
                ret = 0;
+               break;
        default:
                pr_err("setting trigger mode %lu for irq %u failed (%pF)\n",
                       flags, irq, chip->irq_set_type);