mfd: ab3500: world-writable debugfs register-* files
authorVasiliy Kulikov <segoon@openwall.com>
Fri, 4 Feb 2011 12:23:39 +0000 (15:23 +0300)
committerSamuel Ortiz <sameo@linux.intel.com>
Wed, 23 Mar 2011 09:41:47 +0000 (10:41 +0100)
Don't allow everybody to interact with hardware registers.

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/ab3550-core.c

index 5fbca346b998d4a5316790306bc60c32fb8eb623..681984df1c28694216c9d1b292e3ee0ff0ec63a2 100644 (file)
@@ -1053,17 +1053,17 @@ static inline void ab3550_setup_debugfs(struct ab3550 *ab)
                goto exit_destroy_dir;
 
        ab3550_bank_file = debugfs_create_file("register-bank",
-               (S_IRUGO | S_IWUGO), ab3550_dir, ab, &ab3550_bank_fops);
+               (S_IRUGO | S_IWUSR), ab3550_dir, ab, &ab3550_bank_fops);
        if (!ab3550_bank_file)
                goto exit_destroy_reg;
 
        ab3550_address_file = debugfs_create_file("register-address",
-               (S_IRUGO | S_IWUGO), ab3550_dir, ab, &ab3550_address_fops);
+               (S_IRUGO | S_IWUSR), ab3550_dir, ab, &ab3550_address_fops);
        if (!ab3550_address_file)
                goto exit_destroy_bank;
 
        ab3550_val_file = debugfs_create_file("register-value",
-               (S_IRUGO | S_IWUGO), ab3550_dir, ab, &ab3550_val_fops);
+               (S_IRUGO | S_IWUSR), ab3550_dir, ab, &ab3550_val_fops);
        if (!ab3550_val_file)
                goto exit_destroy_address;