spi/s3c64xx: Use managed registration
authorMark Brown <broonie@linaro.org>
Sat, 31 Aug 2013 17:55:53 +0000 (18:55 +0100)
committerMark Brown <broonie@linaro.org>
Wed, 18 Sep 2013 10:02:47 +0000 (11:02 +0100)
Also improve the error reporting on failure and remove a duplicate put.
This provides a small code saving.

Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/spi/spi-s3c64xx.c

index 20dd71237d3b528c8dbff09e4390160bcf163424..8bed27a4108c4d1d5261b658bfec28a237d104ab 100644 (file)
@@ -1428,9 +1428,9 @@ static int s3c64xx_spi_probe(struct platform_device *pdev)
               S3C64XX_SPI_INT_TX_OVERRUN_EN | S3C64XX_SPI_INT_TX_UNDERRUN_EN,
               sdd->regs + S3C64XX_SPI_INT_EN);
 
-       if (spi_register_master(master)) {
-               dev_err(&pdev->dev, "cannot register SPI master\n");
-               ret = -EBUSY;
+       ret = devm_spi_register_master(&pdev->dev, master);
+       if (ret != 0) {
+               dev_err(&pdev->dev, "cannot register SPI master: %d\n", ret);
                goto err3;
        }
 
@@ -1461,16 +1461,12 @@ static int s3c64xx_spi_remove(struct platform_device *pdev)
 
        pm_runtime_disable(&pdev->dev);
 
-       spi_unregister_master(master);
-
        writel(0, sdd->regs + S3C64XX_SPI_INT_EN);
 
        clk_disable_unprepare(sdd->src_clk);
 
        clk_disable_unprepare(sdd->clk);
 
-       spi_master_put(master);
-
        return 0;
 }