staging: gs_fpgaboot: cleanup in gs_fpgaboot_init function
authorDevendra Naga <devendranaga4@gmail.com>
Fri, 24 Oct 2014 20:31:54 +0000 (02:01 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Oct 2014 09:39:55 +0000 (17:39 +0800)
the error path is cleanup to return the correct (function call return value)
error code.

Signed-off-by: Devendra Naga <devendranaga4@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gs_fpgaboot/gs_fpgaboot.c

index 0c18c4c311b4f2f4399663ed97cb2df1b6b6ab05..bf2f898d3853184558a336a0727dcb3f7f0bde73 100644 (file)
@@ -344,43 +344,38 @@ err_out1:
 
 static int __init gs_fpgaboot_init(void)
 {
-       int err, r;
-
-       r = -1;
+       int err;
 
        pr_info("FPGA DOWNLOAD --->\n");
 
        pr_info("FPGA image file name: %s\n", file);
 
        err = init_driver();
-       if (err != 0) {
+       if (err) {
                pr_err("FPGA DRIVER INIT FAIL!!\n");
-               return r;
+               return err;
        }
 
        err = xl_init_io();
        if (err) {
                pr_err("GPIO INIT FAIL!!\n");
-               r = -1;
                goto errout;
        }
 
        err = gs_fpgaboot();
        if (err) {
                pr_err("FPGA DOWNLOAD FAIL!!\n");
-               r = -1;
                goto errout;
        }
 
        pr_info("FPGA DOWNLOAD DONE <---\n");
 
-       r = 0;
-       return r;
+       return 0;
 
 errout:
        finish_driver();
 
-       return r;
+       return err;
 }
 
 static void __exit gs_fpgaboot_exit(void)