zram: allow request end to coincide with disksize
authorSergey Senozhatsky <sergey.senozhatsky@gmail.com>
Sat, 22 Jun 2013 14:21:00 +0000 (17:21 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Aug 2013 05:59:09 +0000 (22:59 -0700)
commit 75c7caf5a052ffd8db3312fa7864ee2d142890c4 upstream.

Pass valid_io_request() checks if request end coincides with disksize
(end equals bound), only fail if we attempt to read beyond the bound.

mkfs.ext2 produces numerous errors:
[ 2164.632747] quiet_error: 1 callbacks suppressed
[ 2164.633260] Buffer I/O error on device zram0, logical block 153599
[ 2164.633265] lost page write due to I/O error on zram0

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Thomas Backlund <tmb@mageia.org>
Cc: Minchan Kim <minchan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/zram/zram_drv.c

index 1742ce55b4a962c5040992587dae88b21a680dd1..a333d44d0cffbeaa1412155a197f88f43ed063c9 100644 (file)
@@ -432,7 +432,7 @@ static inline int valid_io_request(struct zram *zram, struct bio *bio)
        end = start + (bio->bi_size >> SECTOR_SHIFT);
        bound = zram->disksize >> SECTOR_SHIFT;
        /* out of range range */
-       if (unlikely(start >= bound || end >= bound || start > end))
+       if (unlikely(start >= bound || end > bound || start > end))
                return 0;
 
        /* I/O request is valid */