ptp: use list_move instead of list_del/list_add
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Sun, 7 Oct 2012 03:41:50 +0000 (03:41 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 7 Oct 2012 18:52:14 +0000 (14:52 -0400)
Using list_move() instead of list_del() + list_add().

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/ptp.c

index 5b3dd028ce852a267833254bf4c5f28fcf9acf7e..0767043f44a42866d545a8ff843604a3d717af48 100644 (file)
@@ -640,8 +640,7 @@ static void efx_ptp_drop_time_expired_events(struct efx_nic *efx)
                        evt = list_entry(cursor, struct efx_ptp_event_rx,
                                         link);
                        if (time_after(jiffies, evt->expiry)) {
-                               list_del(&evt->link);
-                               list_add(&evt->link, &ptp->evt_free_list);
+                               list_move(&evt->link, &ptp->evt_free_list);
                                netif_warn(efx, hw, efx->net_dev,
                                           "PTP rx event dropped\n");
                        }
@@ -684,8 +683,7 @@ static enum ptp_packet_state efx_ptp_match_rx(struct efx_nic *efx,
 
                        match->state = PTP_PACKET_STATE_MATCHED;
                        rc = PTP_PACKET_STATE_MATCHED;
-                       list_del(&evt->link);
-                       list_add(&evt->link, &ptp->evt_free_list);
+                       list_move(&evt->link, &ptp->evt_free_list);
                        break;
                }
        }
@@ -820,8 +818,7 @@ static int efx_ptp_stop(struct efx_nic *efx)
        /* Drop any pending receive events */
        spin_lock_bh(&efx->ptp_data->evt_lock);
        list_for_each_safe(cursor, next, &efx->ptp_data->evt_list) {
-               list_del(cursor);
-               list_add(cursor, &efx->ptp_data->evt_free_list);
+               list_move(cursor, &efx->ptp_data->evt_free_list);
        }
        spin_unlock_bh(&efx->ptp_data->evt_lock);