ASoC: soc-utils: Don't set unused struct snd_pcm_hardware fields
authorLars-Peter Clausen <lars@metafoo.de>
Fri, 20 Dec 2013 13:20:25 +0000 (14:20 +0100)
committerMark Brown <broonie@linaro.org>
Mon, 30 Dec 2013 13:56:08 +0000 (13:56 +0000)
The ASoC core assumes that the PCM component of the ASoC card transparently
moves data around and does not impose any restrictions on the memory layout or
the transfer speed. It ignores all fields from the snd_pcm_hardware struct for
the PCM driver that are related to this. Setting these fields in the PCM driver
might suggest otherwise though, so rather not set them.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/soc-utils.c

index 5e633659c1b38154ebd1a75aa0e4f005b4f089a0..6ebdfd9a1a1db3d03ae9b071000d9836dd35c06e 100644 (file)
@@ -59,10 +59,6 @@ int snd_soc_params_to_bclk(struct snd_pcm_hw_params *params)
 EXPORT_SYMBOL_GPL(snd_soc_params_to_bclk);
 
 static const struct snd_pcm_hardware dummy_dma_hardware = {
-       .formats                = 0xffffffff,
-       .channels_min           = 1,
-       .channels_max           = UINT_MAX,
-
        /* Random values to keep userspace happy when checking constraints */
        .info                   = SNDRV_PCM_INFO_INTERLEAVED |
                                  SNDRV_PCM_INFO_BLOCK_TRANSFER,