staging: et131x: Add some items to the TODO list
authorMark Einon <mark.einon@gmail.com>
Wed, 11 Sep 2013 13:14:46 +0000 (14:14 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Sep 2013 14:47:43 +0000 (07:47 -0700)
Adding some trivial formatting suggestions made by Dan Carpenter to
the TODO.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/et131x/README

index 9272a24ae61c8250ba770acf8f85e69c610d0f99..8da96a6d2c927946d0c1444fca0472904af7b21b 100644 (file)
@@ -11,7 +11,12 @@ TODO:
        - Look at reducing the number of spinlocks
        - Simplify code in nic_rx_pkts(), when determining multicast_pkts_rcvd
        - Implement NAPI support
-       - in et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet with          kfree_skb().
+       - In et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet with kfree_skb().
+       - Reduce the number of split lines by careful consideration of variable names etc.
+       - Do this in et131x.c:
+                struct fbr_lookup *fbr;
+                fbr = rx_local->fbr[id];
+         Then replace all the instances of "rx_local->fbr[id]" with fbr.
 
 Please send patches to:
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>